Re: MsgBase.get_msg_header() including votes
By: Digital Man to Nightfox on Thu Nov 23 2023 02:43 pm

When using MsgBase.get_msg_header() with the include_votes parameter set to
true, should the header have valid total_votes and upvotes properties?
I've tried using get_msg_header() with the include_votes parameter set to
true, with a message I know has upvotes, but it seems its total_votes and
upvotes are 0. However, when I use get_all_msg_headers() and tell it to

That's by design. In order to calculate a message's vote totals, the entire messagebase index must be read (and used). Voting on a messsage does not modify the message header of that message but creates a new message header that references the message being voted on. I think the MsgBase.get_index() method could be enhanced to calculate the votes and return the tally in its returned array of index objects, if that helps you (it doesn't do that currently).

I see. What I've done in part of DDMsgReader where I want to see vote totals & tallies is to call get_all_msg_headers() and check the header by message number. I'll leave it that way.

Nightfox

---
þ Synchronet þ Digital Distortion: digitaldistortionbbs.com