• src/smblib/smbstr.c

    From rswindell@VERT to CVS commit on Tuesday, March 12, 2019 22:20:32
    src/smblib smbstr.c 1.32 1.33
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smbstr.c
    Log Message:
    smb_netaddr_type() (exposed via JS as netaddr_type()) change:
    prior to rev 1.29 of this file (committed almost exactly one year ago), when called with any string that did not include an '@', would return NET_NONE (0). After rev 1.29, most strings that did not include an '@' would cause the function to return NET_QWK (4) - this was not intentional. The intention was that FidoNet addresses without an '@' would cause this function to return NET_FIDO (2) and I don't exactly remember why that change was made, but unfortunately, it wasn't made very well, so other invalid addresses would be detected as NET_QWK or NET_INTERNET or even NET_UNKNOWN.
    So before and after this commit:
    "" was NET_UNKNOWN, now NET_NONE
    "1" was NET_FIDO, now NET_FIDO
    "1x" was NET_INTERNET, now NET_NONE
    "1:103" was NET_FIDO, now NET_FIDO (this could use some work)
    "x" was NET_QWK, now NET_NONE



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, March 12, 2019 23:43:39
    src/smblib smbstr.c 1.33 1.34
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smbstr.c
    Log Message:
    More strict FidoNet address detection (e.g. so IPv6 addresses aren't
    detected as net_type NET_FIDO).



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net