• src/sbbs3/answer.cpp

    From rswindell@VERT to CVS commit on Thursday, July 11, 2019 17:10:42
    src/sbbs3 answer.cpp 1.102 1.103
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv14360

    Modified Files:
    answer.cpp
    Log Message:
    Don't change useron.misc during logon. This could cause a user's account
    to have the NO_EXASCII (plain-ASCII only) set if the logged in without a successful auto-terminal-type detection.
    And with sbbs_t::term_supports(), we don't need useron.misc to reflect the auto-detected-terminal-type any longer.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, December 27, 2023 17:11:05
    https://gitlab.synchro.net/main/sbbs/-/commit/becf01f28860535195705e43
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Address new GCC build warning in new ssh related code

    comparison of integer expressions of different signedness: `int' and `long unsigned int' [-Wsign-compare]


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Wednesday, January 17, 2024 17:37:50
    https://gitlab.synchro.net/main/sbbs/-/commit/8f9d12c3bca20ab46ef46954
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Whoops, missed this bit.

    Just running git commit --amend doesn't do -a it seems. :)

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Saturday, January 20, 2024 22:41:53
    https://gitlab.synchro.net/main/sbbs/-/commit/8998c57bd800a64ed4a03e6d
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Fix warning reported by nelgin.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Saturday, January 20, 2024 22:42:59
    https://gitlab.synchro.net/main/sbbs/-/commit/3d0d1b91b6646943511dc134
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Actually fix warning reported by nelgin.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sunday, January 21, 2024 01:13:24
    https://gitlab.synchro.net/main/sbbs/-/commit/fe62636c616af59b026c52cb
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Address GCC warning in SSH code

    328:25: warning: `pubkey' may be used uninitialized

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Sunday, January 21, 2024 12:12:26
    https://gitlab.synchro.net/main/sbbs/-/commit/014cb781f152f5900c3f1e8c
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Fix pubkey-first auth attempts.

    Previously, once a pubkey was attempted, you could not use a password.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Monday, January 22, 2024 18:20:28
    https://gitlab.synchro.net/main/sbbs/-/commit/f8c7b04fd7165f58891de6bc
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Set client_socket to INVALID_SOCKET after closing.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Monday, January 22, 2024 18:24:16
    https://gitlab.synchro.net/main/sbbs/-/commit/208b7e794efc327ad1fce90e
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Actually, no real reason to close the socket here... let the caller
    handler it.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, February 16, 2024 18:17:02
    https://gitlab.synchro.net/main/sbbs/-/commit/e4f92887e1ea3d53faf89152
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Log the auto-detected character set (e.g. UTF-8, CP437, PETSCII, or US-ASCII)

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Tuesday, February 27, 2024 14:56:09
    https://gitlab.synchro.net/main/sbbs/-/commit/43c010f6e246b6131d393c7d
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Only log that we're waiting for channel type the first time.

    The other 500 times are implied.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Wednesday, February 28, 2024 08:52:16
    https://gitlab.synchro.net/main/sbbs/-/commit/7bfb1ef12e482ecfb30a9648
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Guard against answer() being called before the first channel is created.

    In this case, just accept whatever we get info on as the "first" one.

    Likely fixes #728

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Wednesday, February 28, 2024 11:00:41
    https://gitlab.synchro.net/main/sbbs/-/commit/dc04dba2dd1317000fcbc79e
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Early-out of the channel type loop for channel errors.

    If there's an error setting the channel or getting the channel
    type, give up on the session immediately.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 02, 2024 15:48:30
    https://gitlab.synchro.net/main/sbbs/-/commit/bf25c42be169b69e9a0e2051
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    TRUE -> true

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 02, 2024 15:48:30
    https://gitlab.synchro.net/main/sbbs/-/commit/84c90ed98b83651479a8ece0
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    client_on() still accepts a BOOL (not bool), so TRUE (not true) is correct

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, March 02, 2024 15:48:30
    https://gitlab.synchro.net/main/sbbs/-/commit/ccce5a7c40c325f3e0628fe1
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Initialize sbbs_t::client and call client_on() as expected for logins

    See sbbs_t::logon() for example

    Note: the client.protocol is still "SSH" here (not "SFTP"). Perhaps that
    should be changed?

    Does any client actually support simultaneous "SSH" and "SFTP" sessions over the same socket?

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Sunday, March 03, 2024 10:36:45
    https://gitlab.synchro.net/main/sbbs/-/commit/479c00be08fcee60913272a4
    Modified Files:
    src/sbbs3/answer.cpp
    Log Message:
    Fix issue when third SSH authentication attempt succeeds

    Because the session is activated on the *next* time through the
    loop, if the third attempt to authenticate (including public key)
    fails, it would leave the session inactive and fail to log in with
    a confusing error about an obsolete cryptlib.

    On success, decrement ssh_failed to ensure another pass through
    the loop.

    Also, add more debug logging around the auth so you can clearly
    see each failure, and log client_socket each time so it's clearly
    grouped.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net