• src/sbbs3/sbbsecho.c

    From rswindell@VERT to CVS commit on Tuesday, March 19, 2019 10:48:22
    src/sbbs3 sbbsecho.c 3.106 3.107
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23463

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix the off-by-one error in the COLS kludge line parsing logic.
    Don't store a columns value of 0 (the default).
    Use SAFEPRINTF in place of sprintf() in parse_control_line().



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, March 19, 2019 11:46:15
    src/sbbs3 sbbsecho.c 3.107 3.108
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv32444

    Modified Files:
    sbbsecho.c
    Log Message:
    Add "COLS" kludge line to EchoMail msgs too (not just NetMail) - oops.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, April 12, 2019 10:39:45
    src/sbbs3 sbbsecho.c 3.109 3.110
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv7631

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove reference to removed/unused enum value: NET_FIDO_ASCII



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, April 15, 2019 01:32:39
    src/sbbs3 sbbsecho.c 3.110 3.111
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv15890

    Modified Files:
    sbbsecho.c
    Log Message:
    Fix potential crash in create_netmail(), bug introduced in rev 3.108:
    When responding to AreaFix requests, it's normal for create_netmail() to be called with a NULL 'msg' argument value - so don't try to dereference it
    (for the "cols" header field value) if it's NULL. Thanks to Mark Lewis for the bug report.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, April 28, 2019 21:14:18
    src/sbbs3 sbbsecho.c 3.111 3.112
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv31205

    Modified Files:
    sbbsecho.c
    Log Message:
    Use FIDO_SOFT_CR (0x8d) rather than the magic number


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, May 27, 2019 23:47:43
    src/sbbs3 sbbsecho.c 3.114 3.115
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26186

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't warn about free disk space for directories that don't exist.
    Log free disk space errors to sbbsecho.log (as well as print to stdout).



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, June 22, 2019 13:27:43
    src/sbbs3 sbbsecho.c 3.115 3.116
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv11356

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

    When processing area manager netmail messages, SBBSecho can modify
    (add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

    Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the node for the sectoin naming.


    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to digital man on Saturday, June 22, 2019 17:13:32
    On 2019 Jun 22 15:27:42, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    Bug-fix: Support [node:<addr>@<domain>] sections in AreaFix changes.

    When processing area manager netmail messages, SBBSecho can modify (add/change) keys in the [node:*] section of the sbbsecho.ini file. Although SBBSecho would read node sections that had a domain (e.g. 5D address) just fine when processing area manager changes and writing those changes back to the sbbsecho.ini, only 4D addresses (no "@domain") were used in the section naming. This could result in duplicate node sections being created in the sbbsecho.ini file (one with a "@domain", one without) and then "bad things" could happen (e.g. BinkP authentication failures, packet authentication failures, etc.).

    i've seen this! never was able to spend time to try to figure out the problem so was unable to report the bug... glad to know that it has been found and fixed! yay!

    Now, when SBBSecho writes linked-node setting to the sbbsecho.ini, it first checks for the full 5D address of the node and if that section exists, modify it, otherwise fall-through to the 3D/4D address of the
    node for the sectoin naming.

    that's like what tickit is doing when it hunts for a system's tic password... look for this and if not found, then look for the other form of address...

    )\/(ark

    Always Mount a Scratch Monkey
    Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
    ... Don't corner something meaner than you.
    ---
    * Origin: (1:3634/12.73)
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, June 28, 2019 15:44:03
    src/sbbs3 sbbsecho.c 3.116 3.117
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    sbbsecho.c
    Log Message:
    Don't need lzh.h here.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, July 25, 2019 19:55:19
    src/sbbs3 sbbsecho.c 3.120 3.121
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv21629

    Modified Files:
    sbbsecho.c
    Log Message:
    When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to digital man on Friday, July 26, 2019 10:10:28
    On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

    When importing fidonet mesages, if there's a Ctrl-A char which is
    *not* the start of a valid control paragraph (kludge line), then
    convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we
    don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes
    causing weird colors or pauses or whatever.

    thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

    )\/(ark

    Once men turned their thinking over to machines in the hope that this would set
    them free. But that only permitted other men with machines to enslave them.
    ... A bachelor lives like a king and dies like a beggar.
    ---
    * Origin: (1:3634/12.73)
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Friday, July 26, 2019 09:47:38
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm


    On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

    When importing fidonet mesages, if there's a Ctrl-A char which is
    *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

    thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

    Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

    digital man

    Synchronet/BBS Terminology Definition #27:
    FOSSIL = Fido/Opus/SEAdog Standard Interface Layer
    Norco, CA WX: 90.5°F, 37.0% humidity, 4 mph N wind, 0.00 inches rain/24hrs

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Friday, July 26, 2019 11:00:42
    Re: src/sbbs3/sbbsecho.c
    By: Digital Man to mark lewis on Fri Jul 26 2019 11:47 am

    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to digital man on Fri Jul 26 2019 12:10 pm


    On 2019 Jul 25 21:55:18, rswindell wrote to CVS commit:

    When importing fidonet mesages, if there's a Ctrl-A char which is *not* the start of a valid control paragraph (kludge line), then convert the Ctrl-A char to an '@'. This handles the situation where someone quotes control paragraphs with Ctrl-A chars, for example, we don't want those Ctrl-A chars being misinterpreted as Ctrl-A codes causing weird colors or pauses or whatever.

    thanks for this! i see similar with pipe codes, too... they're used in the fidonet software listings published in the fidonet or fidogazette newsletters... i've written a note to the maintainer of that list but they are apparently busy in RL and have not gotten back to me... basically the pipe codes are being interpreted in the same manner as the ^A codes... i'm not sure how to handle it, though, other than disabling pipe codes in all fidonet areas via the template area...

    Pipe code support can only be enabled/disabled (in Synchronet) globally. :-(

    Before today... :-)

    digital man

    Synchronet/BBS Terminology Definition #40:
    IMAP = Internet Message Access Protocol
    Norco, CA WX: 94.5°F, 34.0% humidity, 4 mph NNE wind, 0.00 inches rain/24hrs

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, July 29, 2019 20:07:53
    src/sbbs3 sbbsecho.c 3.122 3.123
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8880

    Modified Files:
    sbbsecho.c
    Log Message:
    Remove unused variable.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, July 29, 2019 20:25:53
    src/sbbs3 sbbsecho.c 3.123 3.124
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10902

    Modified Files:
    sbbsecho.c
    Log Message:
    For Mark Lewis:
    When writing non-bundle file paths/names to BSO/FLO files, don't use the
    delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me. The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in SBBSecho, so
    I'll just punt for now and do what Mark asked for. <shrug>



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to digital man on Wednesday, July 31, 2019 18:30:24
    On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    For Mark Lewis:
    When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

    you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

    The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But
    parsing/using the "Flags" control line flags isn't already in
    SBBSecho,

    exactly...

    so I'll just punt for now and do what Mark asked for. <shrug>

    the main thing is the files are no longer killed... attached files really should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

    )\/(ark

    Once men turned their thinking over to machines in the hope that this would set
    them free. But that only permitted other men with machines to enslave them.
    ... But if the handwriting on the wall is a forgery?
    ---
    * Origin: (1:3634/12.73)
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Wednesday, July 31, 2019 22:40:15
    Re: src/sbbs3/sbbsecho.c
    By: mark lewis to digital man on Wed Jul 31 2019 08:30 pm


    On 2019 Jul 29 22:25:52, rswindell wrote to CVS commit:

    Modified Files:
    sbbsecho.c
    Log Message:
    For Mark Lewis:
    When writing non-bundle file paths/names to BSO/FLO files, don't use the delete (^) prefix unless the message has the "Kill Sent" attribute set. This seems kind of wrong to me.

    you are correct... it is wrong... the main thing i wanted/needed was for sbbsecho to not kill file attaches... their deletion appeared to be being triggered by the KillSent bit...

    The KFS "Kill File Sent" flag has been defined in FSC-0053 since 1992, that seems more likely the appropriate flag to determine if a message attachment should be deleted (or not) after being sent. But parsing/using the "Flags" control line flags isn't already in
    SBBSecho,

    exactly...

    so I'll just punt for now and do what Mark asked for. <shrug>

    the main thing is the files are no longer killed...

    They will be if the KILLSENT flag is sent (which is normal).

    attached files really
    should be uncoupled from the KillSent bit completely... they should only be killed if the KFS flag is set if/when sbbsecho implements the Flags control line... yes, i was slightly confused and kept thinking about the KFS flag... plus my brain was burnt from fixing makenl's C code... it has been a long time since i've done any C stuff like that and once i got it figured out, the fix was only like 8 lines added and 2 changed :lol:

    Okay. I'll probably just add the KFS flag checking and remove the checking of the KILLSENT attr bit for that logic.

    digital man

    Synchronet/BBS Terminology Definition #9:
    BSO = Binkley Style Outbound
    Norco, CA WX: 66.2°F, 87.0% humidity, 0 mph SSE wind, 0.00 inches rain/24hrs

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, August 01, 2019 23:31:15
    src/sbbs3 sbbsecho.c 3.124 3.125
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv19947

    Modified Files:
    sbbsecho.c
    Log Message:
    If SBBSecho imports a message with a "CHRS" control line with a value of "UTF-8", set the msg's auxattr MSG_HFIELDS_UTF8 flag because FTS-5003 states:
    "The character set identifier applies to all parts of the message,
    including the header information and the control lines like origin
    and tear line."



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, August 02, 2019 00:22:58
    src/sbbs3 sbbsecho.c 3.125 3.126
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv29414

    Modified Files:
    sbbsecho.c
    Log Message:
    Use the \1FLAGS KFS (parsed crudely from netmail .msg body text) to trigger file-attachment deletion in write_flofile() - not the KILLSENT attribute flag. Export the SMB MSG_KILLSENT auxattr from SMB mail to FTN netmail \1FLAGS KFS.



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, December 04, 2023 21:14:35
    https://gitlab.synchro.net/main/sbbs/-/commit/43fb687f2e138e183f841a42
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix issue when packing netmails for multiple different linked-nodes

    Introduced in commit 15b230af (9 months ago), the first linked-node config (including packet password!) for the first packed netmail message would be reused for subsequent packed netmail messages.

    Thank you to Wilfred van Velzen (2:280/464) for reporting this problem!

    Additional debug-level log message when using a packet password for a newly created packet.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Monday, December 04, 2023 22:57:40
    https://gitlab.synchro.net/main/sbbs/-/commit/28e435bdc2e909f38032afd4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Combine the "new packet" and "password-protected" debug-log lines

    ... to de-clutter the log

    Also, don't log the packet passwords. Folks copy and post sbbsecho.log lines and that could seriously compromise the security of the Interwebs if those super-secret passwords were ever leaked!

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, December 15, 2023 17:25:50
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9d641054b36d9a84cc87da
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, December 31, 2023 17:16:52
    https://gitlab.synchro.net/main/sbbs/-/commit/6e1118af6abf0c55ca608a29
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't use wildcard node packet password (if one exists)

    This also addresses the addresses with 65535 in them in the new debug-level
    log messages "New packet (type x) created for linked-node" .

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, December 31, 2023 17:16:52
    https://gitlab.synchro.net/main/sbbs/-/commit/c2f663c30ab71c7493babab4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log message attributes in human-readable form (not just hexadecimal)

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sunday, January 07, 2024 20:47:22
    https://gitlab.synchro.net/main/sbbs/-/commit/623613492036f9806c225436
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Expand sole-LFs in message text (shouldn't normally be there)

    Expanded to CRLF or just CR (if strip LFs is enabled).

    It is possible for someone to stuff LF-terminated text in a message, so let's account for that possibility upon export to FTNs where LFs are supposed to be ignored.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Wednesday, February 07, 2024 10:47:17
    https://gitlab.synchro.net/main/sbbs/-/commit/20aecd3a4d979af82e3f509b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix more warnings...

    It looks like we may need a set of PRI?TIME macros for printf()ing
    a time_t.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net