From rswindell@VERT to CVS commit on Friday, March 22, 2019 12:27:53
src/comio comio.h 1.9 1.10
Update of /cvsroot/sbbs/src/comio
In directory cvs:/tmp/cvs-serv32122/comio
Modified Files:
comio.h
Log Message:
Use default calling convention (__cdecl) for DLL funcs in Borland builds.
Fix age-old bug with Borland/C++Builder built executables (Windows):
to achieve compatibility with the default __cdecl symbol naming rules of Visual C++, we were using __stdcall convention for DLL functions when
building code with Borland/C++Builder tools and using the default (__cdecl) convention when building with Microsoft (Visual C++) tools. Although this allowed symbols to be located when linking, the calling convention mismatch caused a stack cleanup issue that very rarely manifested itself in a bug
(e.g. exception of some kind in sbbsctrl.exe, usually). Mismatching
the calling conventions was unintentional (I thought the default for MSVC
DLL functions was __stdcall) - but since the calls to MSVC-Built DLL functions worked 99% of the time, I didn't realize there was an underlying issue. So I now work-around the DLL symbol naming mismatch using a command-line option (-a) passed to implib in src/sbbs3/ctrl/makelibs.bat
I had previously worked-around exceptions when calling MSVC DLL functions in sbbsctrl.exe by calling the problematic DLL functions from a timer tick handler rather than a user control (e.g. button) event handler. Those work-arounds can now be removed.
The erroneous "DLLCALL" definition design pattern was replicated (copy/pasted) to many other projects' header files in cvs.synchro.net. In the future, we may want to just remove all instances of *CALL since they now serve no purpose and appear as useless "Kruft" (but do allow us to more-easily globally change DLL function calling conventions if/when necessary in the future).
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
Who's Online
Recent Visitors
System Info
Sysop:
Ruben Figueroa
Location:
Mesquite, Tx
Users:
2
Nodes:
4 (0
/
4)
Uptime:
46:19:33
Calls:
77
Files:
49
Messages:
62,720
Synchronet Oneliners
Denn G@outwest Tue Apr 23 2024 09:33:03 BOO WHO???
Denn@outwest Tue Apr 23 2024 09:39:00 Currently using Synchronet 3.17, moving up to 3.19
TheNerd@canadian Wed Apr 24 2024 17:48:20 Greetings from nerdrage.ddns.net