src/conio ciolib.h 1.100 1.101
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv32122/conio

Modified Files:
ciolib.h
Log Message:
Use default calling convention (__cdecl) for DLL funcs in Borland builds.

Fix age-old bug with Borland/C++Builder built executables (Windows):
to achieve compatibility with the default __cdecl symbol naming rules of Visual C++, we were using __stdcall convention for DLL functions when
building code with Borland/C++Builder tools and using the default (__cdecl) convention when building with Microsoft (Visual C++) tools. Although this allowed symbols to be located when linking, the calling convention mismatch caused a stack cleanup issue that very rarely manifested itself in a bug
(e.g. exception of some kind in sbbsctrl.exe, usually). Mismatching
the calling conventions was unintentional (I thought the default for MSVC
DLL functions was __stdcall) - but since the calls to MSVC-Built DLL functions worked 99% of the time, I didn't realize there was an underlying issue. So I now work-around the DLL symbol naming mismatch using a command-line option (-a) passed to implib in src/sbbs3/ctrl/makelibs.bat

I had previously worked-around exceptions when calling MSVC DLL functions in sbbsctrl.exe by calling the problematic DLL functions from a timer tick handler rather than a user control (e.g. button) event handler. Those work-arounds can now be removed.

The erroneous "DLLCALL" definition design pattern was replicated (copy/pasted) to many other projects' header files in cvs.synchro.net. In the future, we may want to just remove all instances of *CALL since they now serve no purpose and appear as useless "Kruft" (but do allow us to more-easily globally change DLL function calling conventions if/when necessary in the future).



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/conio ciolib.h 1.105 1.106
Update of /cvsroot/sbbs/src/conio
In directory cvs:/tmp/cvs-serv15445

Modified Files:
ciolib.h
Log Message:
Mode numbers can't be over 255 if text_info needs to hold them.




---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/337743edbbe7f9f3f2507e9c
Modified Files:
src/conio/ciolib.h
Log Message:
Change enum text_modes (plural) to enum text_mode (singular)

This is the way.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net