https://gitlab.synchro.net/main/sbbs/-/commit/6abee6374eb0967feb398643
Modified Files:
src/sbbs3/mqtt.c
Log Message:
Fix crash after failing to connect to MQTT broker

We need to call mqtt_shutdown() instead of mqtt_close() to have the mosquitto (loop) thread stopped.

Upon connect failure, call the mqtt_shutdown() *before* calling lprintf->lputs, which would eventually try to MQTT-publish the log message.

The call to mqtt_connect() can block for a while, so raise the log severity
of the "connecting to broker" message from DEBUG to INFO. Otherwise, a bad
MQTT broker address or port would make the servers just appear to hang during initialization, for no reason.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1bc971266525652be3def0a6
Modified Files:
src/sbbs3/mqtt.c
Log Message:
Change the MQTT broker-connect ... successful log message to DEBUG-level

Since we're logging at INFO level when the connect is attempted, we can assume success when we start logging additional init messages.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f8f85f1e4ae337d9fbbc0caa
Modified Files:
src/sbbs3/mqtt.c
Log Message:
Fix CID 493283: Incorrect expression (NO_EFFECT)
Comparing an array to null is not useful: "client->protocol == NULL",
since the test will always evaluate as true.

or will always evaluate as *false* (the array won't ever be NULL). <shrug>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net