• src/sbbs3/chksmb.c

    From rswindell@VERT to CVS commit on Saturday, February 16, 2019 00:26:40
    src/sbbs3 chksmb.c 1.65 1.66
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    chksmb.c
    Log Message:
    Detect and report all messages with overlapping headers.
    This has not actually been an observed problem, but I just realized while working on smb optimizations that this condition would not be reported by chksmb.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rampage@VERT/SESTAR to Digital Man on Saturday, February 16, 2019 09:22:23
    Re: src/sbbs3/chksmb.c
    By: rswindell to CVS commit on Sat Feb 16 2019 02:26:40

    Modified Files:
    chksmb.c
    Log Message:
    Detect and report all messages with overlapping headers.

    i've been seeing something that may be similar with new files added to the system with addfiles (executed from tickit)... when i look at my files listings in the BBS, i'll see "strange" files marked as offline but their name is part of another file's description and their description is part of that other file's description... i have successfully removed those ""files"" from the listings by using the remove command within the BBS... the real files are not affected by this remove AFAICS... this is why i was asking about how to see offline files (on IRC) the other day... i have no idea where to look to try to figure out this problem...


    )\/(ark

    ---
    Synchronet SouthEast Star Mail HUB - SESTAR
  • From Rampage@VERT/SESTAR to Digital Man on Saturday, February 16, 2019 09:24:30
    Re: src/sbbs3/chksmb.c
    By: Rampage to Digital Man on Sat Feb 16 2019 11:22:23

    i forgot to add that i do have terminal captures of what i've seen and done to fix the problem if you need to see them... not sure if they will help but i do have some...


    )\/(ark

    ---
    Synchronet SouthEast Star Mail HUB - SESTAR
  • From Digital Man@VERT to Rampage on Saturday, February 16, 2019 14:19:19
    Re: src/sbbs3/chksmb.c
    By: Rampage to Digital Man on Sat Feb 16 2019 11:22 am

    Re: src/sbbs3/chksmb.c
    By: rswindell to CVS commit on Sat Feb 16 2019 02:26:40

    Modified Files:
    chksmb.c
    Log Message:
    Detect and report all messages with overlapping headers.

    i've been seeing something that may be similar with new files added to the system with addfiles (executed from tickit)... when i look at my files listings in the BBS, i'll see "strange" files marked as offline but their name is part of another file's description and their description is part of that other file's description... i have successfully removed those ""files"" from the listings by using the remove command within the BBS... the real files are not affected by this remove AFAICS... this is why i was asking about how to see offline files (on IRC) the other day... i have no idea where to look to try to figure out this problem...

    Whatever the issue, it's not related to SMB as the current filebase doesn't use SMB. If you figure out how to reproduce the problem or send me the data files (data/dirs/*) for the corrupt areas, I'll have a look-see.

    digital man

    This Is Spinal Tap quote #1:
    Nigel Tufnel: These go to eleven.
    Norco, CA WX: 56.2F, 51.0% humidity, 4 mph N wind, 0.12 inches rain/24hrs

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, February 16, 2019 19:24:51
    src/sbbs3 chksmb.c 1.66 1.67
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    chksmb.c
    Log Message:
    If message's index offset exactly matches another message, that's already reported as "Duplicate index offset", so overlapping headers means the
    index offset must not be an exact duplicate, so we don't report the same corrupt message parameter (its offset into the header file) 2 different
    ways.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rampage@VERT/SESTAR to Digital Man on Sunday, February 17, 2019 10:53:21
    Re: src/sbbs3/chksmb.c
    By: Digital Man to Rampage on Sat Feb 16 2019 16:19:19

    Whatever the issue, it's not related to SMB as the current
    filebase doesn't use SMB.

    yeah, i know it doesn't use SMB :) it was just the similarity of parts overlapping that drew my attention...

    If you figure out how to reproduce the problem or send me the
    data files (data/dirs/*) for the corrupt areas, I'll have a
    look-see.

    i hadn't thought about saving the data files before cleaning them up... i'll keep an eye out and grab them the next time i see the problem and get them to you...


    )\/(ark

    ---
    Synchronet SouthEast Star Mail HUB - SESTAR
  • From mark lewis@VERT to Digital Man on Monday, February 18, 2019 10:53:10
    On 2019 Feb 16 16:19:18, you wrote to Rampage:

    but their name is part of another file's description and their
    description is part of that other file's description... i have
    successfully removed those ""files"" from the listings by using the
    remove command within the BBS... the real files are not affected by
    this remove AFAICS... this is why i was asking about how to see offline
    files (on IRC) the other day... i have no idea where to look to try to
    figure out this problem...

    Whatever the issue, it's not related to SMB as the current filebase doesn't use SMB. If you figure out how to reproduce the problem or
    send me the data files (data/dirs/*) for the corrupt areas, I'll have
    a look-see.

    i don't know if you saw it or not but i did send you an email sunday evening with two of my files bases' database files zipped and two screenshots of the problem... one shot for each area...

    FWIW: the only things touching tho filebases are addfiles (via tickit) and sbbs... nothing 3rd party or self-written...

    )\/(ark

    Always Mount a Scratch Monkey
    Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
    ... When man builds better mousetraps, nature builds better mice.
    ---
    * Origin: (1:3634/12.73)
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to mark lewis on Monday, February 18, 2019 12:11:15
    Re: src/sbbs3/chksmb.c
    By: mark lewis to Digital Man on Mon Feb 18 2019 12:53 pm


    On 2019 Feb 16 16:19:18, you wrote to Rampage:

    but their name is part of another file's description and their
    description is part of that other file's description... i have
    successfully removed those ""files"" from the listings by using the
    remove command within the BBS... the real files are not affected by
    this remove AFAICS... this is why i was asking about how to see offline
    files (on IRC) the other day... i have no idea where to look to try to
    figure out this problem...

    Whatever the issue, it's not related to SMB as the current filebase doesn't use SMB. If you figure out how to reproduce the problem or
    send me the data files (data/dirs/*) for the corrupt areas, I'll have
    a look-see.

    i don't know if you saw it or not but i did send you an email sunday evening with two of my files bases' database files zipped and two screenshots of the problem... one shot for each area...

    FWIW: the only things touching tho filebases are addfiles (via tickit) and sbbs... nothing 3rd party or self-written...

    I saw and saved the email. I haven't looked at it yet. Most likely it's an addfiles bug. Do you have the input file to addfiles and the command-line that may have caused the corruption?

    digital man

    Synchronet/BBS Terminology Definition #32:
    FTSC = FidoNet Technical Standards Committee
    Norco, CA WX: 55.0F, 35.0% humidity, 5 mph SSW wind, 0.00 inches rain/24hrs

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From mark lewis@VERT to Digital Man on Monday, February 18, 2019 19:13:54
    On 2019 Feb 18 14:11:14, you wrote to me:

    FWIW: the only things touching tho filebases are addfiles (via tickit)
    and sbbs... nothing 3rd party or self-written...

    I saw and saved the email. I haven't looked at it yet. Most likely
    it's an addfiles bug.

    ok...

    Do you have the input file to addfiles and the command-line that may
    have caused the corruption?

    i can dig out the command line from my logs but tickit deletes the files.bbs file it creates when it is finished... it actually writes a new one for each file being imported...

    it is actually a pretty generic command... only the area ID (and uploader name in my case) changes each time while the rest of the line stays the same... here's one of the 5 or 6 executed today...

    Feb 18 16:22:07 sestar sbbs: evnt TICKIT Executing: '/sbbs/exec/addfiles fdist-xofchubs -x "XOFCHUBSLST File Dist" -zd +/sbbs/temp/event/tickit-files.bbs 24 13
    /sbbs/data/addfiles.log 2>&1'.

    none of the areas processed today show any corruption at this time...

    )\/(ark

    Always Mount a Scratch Monkey
    Do you manage your own servers? If you are not running an IDS/IPS yer doin' it wrong...
    ... My hobbies include closing the elevator door before someone else gets on. ---
    * Origin: (1:3634/12.73)
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net