• src/smblib/smblib.c

    From rswindell@VERT to CVS commit on Saturday, February 16, 2019 02:09:15
    src/smblib smblib.c 1.183 1.184
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv29070

    Modified Files:
    smblib.c
    Log Message:
    Performance optimization: When performing sequential index or header reads,
    the read buffer may be utilized more efficiently if you do *not* perform an (unnecessary) seek operation just before the read. By eliminating unnecessary seeks in smb_getmsgidx() and smb_getmsghdr(), I was able to reduce the time required to load 9000+ index and header records over a network (Samba/CIFS) share from 15+ seconds to less than 5.


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, February 18, 2019 21:11:53
    src/smblib smblib.c 1.185 1.186
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv17040

    Modified Files:
    smblib.c
    Log Message:
    Fixed a couple of function return-value comments.


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, March 19, 2019 14:02:02
    src/smblib smblib.c 1.186 1.187
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smblib.c
    Log Message:
    Use DEFFILEMODE for file creation mode in smb_addcrc() - another potential
    for file permissions issues when smblib creates *.sch files.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, April 05, 2019 23:00:14
    src/smblib smblib.c 1.187 1.188
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv10033

    Modified Files:
    smblib.c
    Log Message:
    smb_copymsgmem() fix:
    Did not clear/set convenience pointers (e.g. msg.subj), so they would point
    to the source message hfield_dat buffers which may be freed or garbage. Apparently nothing that used smb_copymsgmem() used the convenience pointers (before now), so it hasn't been a problem before now. <shrug>
    It became a problem becaue I'm going to use this function in js_put_msg_header to fix a problem where the underlying smbmsg_t representation is not current even after MsgBase.put_msg_header() is used.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, April 28, 2019 18:56:48
    src/smblib smblib.c 1.193 1.194
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv7937

    Modified Files:
    smblib.c
    Log Message:
    Actually set and clear the smbmsg_t.forward_path (SMTPFORWARDPATH) convenience pointer - apparently this has never actually been used before.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, May 05, 2019 02:06:52
    src/smblib smblib.c 1.197 1.198
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smblib.c
    Log Message:
    Clear the new convenience pointers: text_subtype and text_charset
    in clear_convenience_ptrs() - otherwise they can be double-freed when the message (smbmsg_t) is copied with smb_copymsgmem().



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, July 07, 2019 22:16:10
    src/smblib smblib.c 1.199 1.200
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv18855

    Modified Files:
    smblib.c
    Log Message:
    Increment SMBLIB version 2.61 (added new function: smb_msg_is_utf8).



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wednesday, July 17, 2019 18:09:12
    src/smblib smblib.c 1.200 1.201
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv17444

    Modified Files:
    smblib.c
    Log Message:
    Address warnings reported by Visual Studio 2017 - Windows XP (v141_xp) toolset


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, July 20, 2019 10:10:27
    src/smblib smblib.c 1.201 1.202
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smblib.c
    Log Message:
    Fix some new GCC warnings about printf arg type mismatches.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, December 29, 2023 17:10:28
    https://gitlab.synchro.net/main/sbbs/-/commit/47fe4a60247147dc217ad02b
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    Fix stale comments (msg.offset became msg.idx_offset a couple years back).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net