• src/sbbs3/ftpsrvr.c

    From deuce@VERT to CVS commit on Tuesday, May 07, 2019 12:12:33
    src/sbbs3 ftpsrvr.c 1.489 1.490
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10196

    Modified Files:
    ftpsrvr.c
    Log Message:
    Fix crash introduced in 1.485.

    When the command is MLST, fp is NULL, so should not be passed to ftell().



    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Thursday, May 30, 2019 18:31:13
    src/sbbs3 ftpsrvr.c 1.490 1.491
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25642

    Modified Files:
    ftpsrvr.c
    Log Message:
    Fix bug where Synchronet FTP Server %s-%s Ready message did not have a
    reply code. Maybe this used to be on the same line as the BBS name?




    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to deuce on Thursday, May 30, 2019 23:18:10
    Re: src/sbbs3/ftpsrvr.c
    By: deuce to CVS commit on Thu May 30 2019 08:31 pm

    src/sbbs3 ftpsrvr.c 1.490 1.491
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25642

    Modified Files:
    ftpsrvr.c
    Log Message:
    Fix bug where Synchronet FTP Server %s-%s Ready message did not have a
    reply code. Maybe this used to be on the same line as the BBS name?

    No, I think you're misreading the FTP spec (RFC959):
    Thus the format for multi-line replies is that the first line
    will begin with the exact required reply code, followed
    immediately by a Hyphen, "-" (also known as Minus), followed by
    text. The last line will begin with the same code, followed
    immediately by Space <SP>, optionally some text, and the Telnet
    end-of-line code.

    digital man

    Synchronet/BBS Terminology Definition #12:
    CBM = Commodore Business Machines
    Norco, CA WX: 55.6°F, 95.0% humidity, 2 mph ESE wind, 0.00 inches rain/24hrs

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From deuce@VERT to CVS commit on Friday, May 31, 2019 06:39:17
    src/sbbs3 ftpsrvr.c 1.491 1.492
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28963

    Modified Files:
    ftpsrvr.c
    Log Message:
    Revert previous change. NetLogger has the bug, not Synchronet.




    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 09, 2024 17:20:47
    https://gitlab.synchro.net/main/sbbs/-/commit/339599be4e8c05ed8e3fabe9
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Fix MSLT and MSLD response for QWK packet filename in root directory

    Reusing the variable 'str' here for multiple purposes meant the QWK packet filename was overwritten by the owner name (the system's BBS-ID):

    mlsd
    229 Entering Extended Passive Mode (|||2001|)
    150 Opening ASCII mode data connection for MLSD.
    Type=file;Perm=r;UNIX.ownername=VERT; 00index
    Type=cdir;Perm=elc;UNIX.ownername=VERT; /
    Type=file;Perm=r;UNIX.ownername=VERT; VERT

    That last file there should have been "VERT.qwk"

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 09, 2024 17:20:47
    https://gitlab.synchro.net/main/sbbs/-/commit/3a25ed550b4f5d6563da0d8a
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Use safe string copying in get_owner_name() via strlcpy()

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 09, 2024 17:20:47
    https://gitlab.synchro.net/main/sbbs/-/commit/bb4ccdaad2c07262560ddab9
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Restore ftpalias.cfg support for MLSx commands

    Support was accidentally removed as part of commit 0d01544d, meaning
    the ftpalias.cfg wasn't used at all in responses to the MLSx commands as reported by Max (WESTLINE) using Total Commander, FileZilla and Directory
    opus. The traditional "LIST" commands still worked fine with ftpalias.cfg contents just fine.

    The reason this code was accidentally removed was due to the errant
    copy/pasted comparison with startup->html_index_file that did not belong here and made the block appear related to HTML index file generation. It was not. This was just a bug in the initial implementation of MLSx support in
    commit d4deb4b3.

    Also included in this commit:
    - Return the date/size of the user's QWK packet file, if it exists, in MLSx
    response.
    - send_mlsx_entry() won't report negative time_t values as file modify dates
    (flength returns -1 upon failure/file-not-found).
    - get_owner_name() returns the string, making it easier to use in function
    calls.

    There appears to still be some work to do to make the MLSx commands fully compliant with RFC 3659 (e.g. "mlst filename" from ftpalias.cfg should work
    but does not), but at least FileZilla displays ftpalias.cfg files and directories correctly now.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Wednesday, February 07, 2024 13:41:41
    https://gitlab.synchro.net/main/sbbs/-/commit/e1b0164230ba4987cae0c3df
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Mostly time_t printfs, but also an odd bit where it's printing a
    value that's not an off_t as one.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net