• src/sbbs3/writemsg.cpp

    From rswindell@VERT to CVS commit on Thursday, March 07, 2019 21:48:21
    src/sbbs3 writemsg.cpp 1.142 1.143
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    writemsg.cpp
    Log Message:
    Fix (new) potential dereference of NULL (top) pointer in writemsg(), reported by Deuce. If 'top' is passed in as NULL, assign a blank string constant to it since we dereference top a few places in this function and pass it to putmsg().



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, April 28, 2019 20:55:03
    src/sbbs3 writemsg.cpp 1.147 1.148
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27853

    Modified Files:
    writemsg.cpp
    Log Message:
    Fix crash introduced in previous commit (rev 1.147) of this file (on Apr-16), when the user is using the internal msg editor (useron_xedit == 0) and
    replying to a message.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, April 29, 2019 17:36:14
    src/sbbs3 writemsg.cpp 1.150 1.151
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv28446

    Modified Files:
    writemsg.cpp
    Log Message:
    Use quote prefixes for auto-message body which allows us to word-wrap
    nicely when displaying at various terminal widths.


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, April 29, 2019 17:48:34
    src/sbbs3 writemsg.cpp 1.151 1.152
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    writemsg.cpp
    Log Message:
    Resolve GCC warning: enumeration value 'XEDIT_SOFT_CR_UNDEFINED' not handled
    in switch



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sunday, July 07, 2019 19:26:01
    src/sbbs3 writemsg.cpp 1.155 1.156
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23003

    Modified Files:
    writemsg.cpp
    Log Message:
    When the created message is UTF-8, translate (from CP-437 to UTF-8) any
    user signature (.sig file) or editor created message tag (editor.tag file) contents before adding to message base.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, July 08, 2019 20:27:32
    src/sbbs3 writemsg.cpp 1.157 1.158
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6392

    Modified Files:
    writemsg.cpp
    Log Message:
    Use enum values from (new file) cp437defs.h



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Saturday, July 20, 2019 10:06:44
    src/sbbs3 writemsg.cpp 1.161 1.162
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    writemsg.cpp
    Log Message:
    Always check for the existence of RESULT.ED file after using an external
    editor even if the editor was configured for QuickBBS/MSGINF drop files.
    Don't use the subject line from RESULT.ED when the read-only subject mode
    is used.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Nightfox@VERT/DIGDIST to rswindell on Sunday, July 21, 2019 09:21:34
    Re: src/sbbs3/writemsg.cpp
    By: rswindell to CVS commit on Sat Jul 20 2019 12:06 pm

    Modified Files:
    writemsg.cpp
    Log Message:
    Always check for the existence of RESULT.ED file after using an external editor even if the editor was configured for QuickBBS/MSGINF drop files. Don't use the subject line from RESULT.ED when the read-only subject mode is used.

    It looks like that works. Thanks!

    Nightfox

    ---
    Synchronet Digital Distortion: digitaldistortionbbs.com
  • From Digital Man@VERT to Nightfox on Sunday, July 21, 2019 22:35:45
    Re: src/sbbs3/writemsg.cpp
    By: Nightfox to rswindell on Sun Jul 21 2019 11:21 am

    Re: src/sbbs3/writemsg.cpp
    By: rswindell to CVS commit on Sat Jul 20 2019 12:06 pm

    Modified Files:
    writemsg.cpp
    Log Message:
    Always check for the existence of RESULT.ED file after using an external editor even if the editor was configured for QuickBBS/MSGINF drop files. Don't use the subject line from RESULT.ED when the read-only subject mode is used.

    It looks like that works. Thanks!

    Cool. I see you added your version details to line 3 as well:

    Editor SlyEdit 1.67 Beta (2019-07-19)

    Nice!

    digital man

    Synchronet/BBS Terminology Definition #73:
    Telenet = Proprietary packet switched network (variant on X.75)
    Norco, CA WX: 66.6F, 82.0% humidity, 4 mph SE wind, 0.00 inches rain/24hrs

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Nightfox@VERT/DIGDIST to Digital Man on Monday, July 22, 2019 08:09:32
    Re: src/sbbs3/writemsg.cpp
    By: Digital Man to Nightfox on Mon Jul 22 2019 12:35 am

    It looks like that works. Thanks!

    Cool. I see you added your version details to line 3 as well:

    Editor SlyEdit 1.67 Beta (2019-07-19)

    Nice!

    Yep, I figured I might as well have it write that too.

    Nightfox

    ---
    Synchronet Digital Distortion: digitaldistortionbbs.com
  • From Digital Man@VERT to Nightfox on Monday, July 22, 2019 11:53:47
    Re: src/sbbs3/writemsg.cpp
    By: Nightfox to Digital Man on Mon Jul 22 2019 10:09 am

    Re: src/sbbs3/writemsg.cpp
    By: Digital Man to Nightfox on Mon Jul 22 2019 12:35 am

    It looks like that works. Thanks!

    Cool. I see you added your version details to line 3 as well:

    Editor SlyEdit 1.67 Beta (2019-07-19)

    Nice!

    Yep, I figured I might as well have it write that too.

    It's helpful when reporting issues or diagnosing problems. Appreciated.

    digital man

    Synchronet/BBS Terminology Definition #82:
    XPDEV = Cross-platform Development
    Norco, CA WX: 89.7F, 43.0% humidity, 5 mph ESE wind, 0.00 inches rain/24hrs

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, July 23, 2019 20:05:44
    src/sbbs3 writemsg.cpp 1.163 1.164
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/home/rswindell/sbbs/src/sbbs3

    Modified Files:
    writemsg.cpp
    Log Message:
    Address printf precision arg warning.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, July 25, 2019 01:55:02
    src/sbbs3 writemsg.cpp 1.164 1.165
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv25255

    Modified Files:
    writemsg.cpp
    Log Message:
    We're storing the charset of locally created messages in the (new) SMB hfield: FIDOCHARSET, no longer FIDOCTRL.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, July 25, 2019 20:18:35
    src/sbbs3 writemsg.cpp 1.165 1.166
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv24329

    Modified Files:
    writemsg.cpp
    Log Message:
    process_edited_text():
    When message text contains an invalid or possibly dangerous Ctrl-A code, convert the Ctrl-A to an '@' char.
    Only Ctrl-A *attribute* codes will be allowed in message text
    (e.g. not ^AP, ^AL, ^A", etc.).



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thursday, July 25, 2019 22:20:04
    src/sbbs3 writemsg.cpp 1.166 1.167
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv6418

    Modified Files:
    writemsg.cpp
    Log Message:
    Capture/use the "NOTE:" FTN-kludge added by external message editors.
    Correctly support CR-terminated FTN-kludge lines (per spec, no LF is required). Save the revision of this source file as the editor details for raw (writemsg) and internal (msgeditor) created messages.


    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, August 02, 2019 02:53:02
    src/sbbs3 writemsg.cpp 1.167 1.168
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv18198

    Modified Files:
    writemsg.cpp
    Log Message:
    Auto-detect ZMODEM upload of message text in internal line editor.
    Discards any previously quoted/typed text, but remains in the editor with the uploaded text available for append or edit.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Friday, August 02, 2019 04:53:31
    src/sbbs3 writemsg.cpp 1.168 1.169
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv8142

    Modified Files:
    writemsg.cpp
    Log Message:
    Add a /UPLOAD command which works with any/all configured protocols
    (in addition to the auto-ZMODEM upload detection). Using an evil "goto" for code reuse.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, December 21, 2023 12:38:45
    https://gitlab.synchro.net/main/sbbs/-/commit/daf8fa55aa08b39bf8b4fc6e
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    Fix internal line editor buffer overflow (heap corruption)

    ... wasn't accounting for length of the 'top' buffer (when supplied).

    Also, for raw input mode:
    - flush the input buffer (stray LF) before accepting input
    - turn off raw input mode if run out of bytes (max lines/length reached)

    I was investigating the reported error by Nelgin:
    !ERROR in writemsg.cpp line 1214 (msgeditor) checking
    "max lines (20) exceeded" access=46
    which I was unable to reproduce, when I encountered the issues addressed
    in this commit.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, December 26, 2023 16:04:06
    https://gitlab.synchro.net/main/sbbs/-/commit/3057bcc20148e3d93d1052a5
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    Insure uploaded text ends in a new-line

    We were appending .sig files to uploaded text, which may not have ended
    in an LF or CRLF sequence. This fixes that.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Friday, December 29, 2023 17:10:28
    https://gitlab.synchro.net/main/sbbs/-/commit/ee5e3e8ee949f73113909680
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    Fix an error path FILE* leak (CID 462238)

    Go ahead and fix false-positive CID 33482 by adding a NULL check to quotestr()

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, January 23, 2024 18:37:49
    https://gitlab.synchro.net/main/sbbs/-/commit/1321d7f537df2b0eb0c99f33
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    When editing a message, pass the proper to/from/subj/area to drop file

    Fixes issue #704 - not just for JS bbs.edit_msg(), but for all uses of the underlying sbbs_t::editmsg() function.

    Replaced one specific comparison of subnum == INVALID_SUB with call to is_valid_subnum() just to be consistent. No functional change there.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tuesday, February 13, 2024 20:37:50
    https://gitlab.synchro.net/main/sbbs/-/commit/00afb97cc670fdf3e11aa839
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    Improvements to UTF-8 capable external editor support

    1. Add an 8th line to MSGINF (for SlyEdit): the character set expected
    (either "CP437", the default, or "UTF-8") based on the SCFG configuration
    2. Don't apply "Soft-CR" (0x8D) stripping/expansion for UTF-8 editors

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, February 15, 2024 19:24:53
    https://gitlab.synchro.net/main/sbbs/-/commit/0dc20c1f9bf66ae376b0f22d
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    If the quotes.txt file doesn't exist with the right case, try any case

    (but prefer the proper/configured case, based on config in SCFG).

    Works around a problem where DDMsgReader always creates QUOTES.TXT (never quotes.txt), but SBBS tries to read in the file with the case it expects.
    This wouldn't be a problem on case-insensitive file systems (Windows).

    Resolves the writemsg.cpp error reported by Nelgin

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thursday, February 15, 2024 21:37:00
    https://gitlab.synchro.net/main/sbbs/-/commit/f894f62108ad3251bfcba84c
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    Fix bug in previous commit to this file

    I'm surprised this didn't create a warning somewhere: treating char* as a
    bool!

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tuesday, February 20, 2024 23:57:53
    https://gitlab.synchro.net/main/sbbs/-/commit/f754ad9057b0cd076bcf57b1
    Modified Files:
    src/sbbs3/writemsg.cpp
    Log Message:
    Allow UTF-8 sequences in message subjects (passing K_UTF8 to getstr)

    This was the behavior for all string input in SBBS until recently
    (Commit 55ccda6294f82506), with this change, an exception is being
    made for message subjects, but the vast majority of other string
    input is still limited to single-byte (i.e. US-ASCII or CP437)
    characters.

    This should fix issue #720

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net