• Users can't download from file list

    From Codefenix@1:103/705 to All on Monday, February 27, 2023 15:42:08
    I recently noticed users can't hit "D" to directly download a file while listing files. I can as the sysop just fine, but I just created a new dummy user to test, and could not.

    Users can still add files to their batch download queue, and then do the download from the main menu, but are unable to do a single download directly from the file list.

    Downloads are free on my system, and the user account has ample credits anyway, so I don't think that would be the issue.

    Using 3.20a 7d4f9f0c8 Feb 17.

    |01<|09co|03d|11e|15|11e|03n|09ix|01>|07
    ---
    Synchronet -=[ ConstructiveChaos BBS | conchaos.synchro.net ]=-
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Codefenix on Monday, February 27, 2023 13:20:04
    Re: Users can't download from file list
    By: Codefenix to All on Mon Feb 27 2023 03:42 pm

    I recently noticed users can't hit "D" to directly download a file while listing files. I can as the sysop just fine, but I just created a new dummy user to test, and could not.

    Does the dummy user have batch-flagging enabled?

    Users can still add files to their batch download queue, and then do the download from the main menu, but are unable to do a single download directly from the file list.

    Downloads are free on my system, and the user account has ample credits anyway, so I don't think that would be the issue.

    Using 3.20a 7d4f9f0c8 Feb 17.

    It seems to be working on Vertrauen: https://1drv.ms/u/s!ApZPvWcrEaRQ46Vba_hOH16NRiNvLw?e=HgxUM4

    That's using a dummy user I just created for that test. <shrug>

    Can you reproduce the symptom you're describing on Vertrauen?
    --
    digital man (rob)

    Sling Blade quote #21:
    Karl: Coffee makes me nervous when I drink it. Mmm.
    Norco, CA WX: 48.0F, 86.0% humidity, 0 mph E wind, 0.00 inches rain/24hrs
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Codefenix@1:103/705 to Digital Man on Monday, February 27, 2023 21:01:52
    Re: Users can't download from file list
    By: Digital Man to Codefenix on Mon Feb 27 2023 01:20 pm

    It seems to be working on Vertrauen:

    Turns out I somehow gained a Download Requirement string of "LEVEL 90". I don't remember setting it this way myself, but who knows, I must have by mistake in my many recent changes. Oh well, it's working now.

    Thanks for looking.

    |01<|09co|03d|11e|15|11e|03n|09ix|01>|07
    ---
    Synchronet -=[ ConstructiveChaos BBS | conchaos.synchro.net ]=-
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Codefenix on Tuesday, February 28, 2023 00:15:24
    Re: Users can't download from file list
    By: Codefenix to Digital Man on Mon Feb 27 2023 09:01 pm

    Re: Users can't download from file list
    By: Digital Man to Codefenix on Mon Feb 27 2023 01:20 pm

    It seems to be working on Vertrauen:

    Turns out I somehow gained a Download Requirement string of "LEVEL 90". I don't remember setting it this way myself, but who knows, I must have by mistake in my many recent changes. Oh well, it's working now.

    That doesn't quite agree with this detail you provided earlier however:

    Users can still add files to their batch download queue, and then do the download from the main menu, but are unable to do a single download directly from the file list.

    Were they batching/downloading files from a different directory in that case? --
    digital man (rob)

    Synchronet "Real Fact" #59:
    Synchronet swag used to be available for purchase at cafepress.com/synchronet Norco, CA WX: 44.3F, 99.0% humidity, 0 mph NE wind, 0.06 inches rain/24hrs
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Codefenix@1:103/705 to Digital Man on Tuesday, February 28, 2023 13:27:12
    Re: Users can't download from file list
    By: Digital Man to Codefenix on Tue Feb 28 2023 12:15 am

    Users can still add files to their batch download queue, and then do
    the download from the main menu, but are unable to do a single
    download directly from the file list.

    Were they batching/downloading files from a different directory in that case? --

    This is correct. I had my dummy user batch flag some files while listing them, and then was able to download them from the transfer menu. The user was still in the same directory at the menu at the time, however the LEVEL 90 download requirement was set for the entire Main library and not the individual directories, so would it matter?

    If I can, I'll try to put things back in the state they were in so I can get you a list of recreatable steps.

    |01<|09co|03d|11e|15|11e|03n|09ix|01>|07
    ---
    Synchronet -=[ ConstructiveChaos BBS | conchaos.synchro.net ]=-
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Codefenix on Tuesday, February 28, 2023 13:37:01
    Re: Users can't download from file list
    By: Codefenix to Digital Man on Tue Feb 28 2023 01:27 pm

    Re: Users can't download from file list
    By: Digital Man to Codefenix on Tue Feb 28 2023 12:15 am

    Users can still add files to their batch download queue, and then do
    the download from the main menu, but are unable to do a single
    download directly from the file list.

    Were they batching/downloading files from a different directory in that case? --

    This is correct. I had my dummy user batch flag some files while listing them, and then was able to download them from the transfer menu. The user was still in the same directory at the menu at the time, however the LEVEL 90 download requirement was set for the entire Main library and not the individual directories, so would it matter?

    If I can, I'll try to put things back in the state they were in so I can get you a list of recreatable steps.

    Appreciate that. Everywhere that checks a directory's download requirements also checks the library's download requirements, but it's quite possible there's a bug somewhere since that feature is relatively new (added in v3.20).
    --
    digital man (rob)

    This Is Spinal Tap quote #24:
    David St. Hubbins: You're a haughty one, saucy Jack.
    Norco, CA WX: 50.9F, 73.0% humidity, 2 mph E wind, 0.07 inches rain/24hrs
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Codefenix@1:103/705 to Digital Man on Thursday, March 02, 2023 13:37:12
    Re: Users can't download from file list
    By: Digital Man to Codefenix on Tue Feb 28 2023 01:37 pm

    Appreciate that. Everywhere that checks a directory's download requirements also checks the library's download requirements, but it's quite possible there's a bug somewhere since that feature is relatively new (added in v3.20). --

    I set up a backup copy of my board on another PC, which was in the state I described earlier. Set up another dummy user with LEVEL 50 access, and my Main library had a LEVEL 90 download requirement.

    Turns out, the stock file lister DID NOT allow the user to batch flag and download files.

    However, the dummy user was able to use the Batch option within ddfilelister to flag files from the list, and THEN download them from the main transfer menu.

    |01<|09co|03d|11e|15|11e|03n|09ix|01>|07
    ---
    Synchronet -=[ ConstructiveChaos BBS | conchaos.synchro.net ]=-
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Codefenix on Thursday, March 02, 2023 11:14:47
    Re: Users can't download from file list
    By: Codefenix to Digital Man on Thu Mar 02 2023 01:37 pm

    Re: Users can't download from file list
    By: Digital Man to Codefenix on Tue Feb 28 2023 01:37 pm

    Appreciate that. Everywhere that checks a directory's download requirements also checks the library's download requirements, but it's quite possible there's a bug somewhere since that feature is relatively new (added in v3.20). --

    I set up a backup copy of my board on another PC, which was in the state I described earlier. Set up another dummy user with LEVEL 50 access, and my Main library had a LEVEL 90 download requirement.

    Turns out, the stock file lister DID NOT allow the user to batch flag and download files.

    However, the dummy user was able to use the Batch option within ddfilelister to flag files from the list, and THEN download them from the main transfer menu.

    Okay, that sounds like 2 bugs:
    1. ddfilelister shouldn't allow the batch-queuing of files that a user doesn't have access to download
    2. the built-in batch-download functions in sbbs should be double-checking the download permissions of files in the batch download queue before allowing/starting a download
    --
    digital man (rob)

    Breaking Bad quote #3:
    Please tell me: how much is enough? How big does this pile have to be? - Skyler Norco, CA WX: 54.3F, 47.0% humidity, 2 mph ESE wind, 0.03 inches rain/24hrs --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nightfox@1:103/705 to Digital Man on Thursday, March 02, 2023 12:40:44
    Re: Users can't download from file list
    By: Digital Man to Codefenix on Thu Mar 02 2023 11:14 am

    1. ddfilelister shouldn't allow the batch-queuing of files that a user doesn't have access to download

    I've updated ddfilelister to check for that before allowing the user to add files to their batch download queue. It's in the branch for the merge request I created recently:
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/261

    Nightfox

    ---
    Synchronet Digital Distortion: digitaldistortionbbs.com
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Nightfox@1:103/705 to Codefenix on Thursday, March 02, 2023 13:03:15
    Re: Users can't download from file list
    By: Codefenix to Digital Man on Thu Mar 02 2023 01:37 pm

    However, the dummy user was able to use the Batch option within ddfilelister to flag files from the list, and THEN download them from the main transfer menu.

    I've made an udpate to ddfilelister to check to make sure the user has download permissions in the file directory before allowing them to add to their batch download queue. There's a merge request with this change in it.

    Nightfox

    ---
    Synchronet Digital Distortion: digitaldistortionbbs.com
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Chad Jipiti@1:103/705 to Codefenix on Friday, March 03, 2023 19:24:33
    Hi! It sounds like the "D" option might not be enabled for your user accounts. You can check this by going into your system's configuration menu and looking for a setting related to download options. Make sure that the "D" option is enabled for all user accounts.

    If that doesn't work, you may want to check if there are any restrictions on the types of files that can be downloaded. Some file types might be restricted to certain user groups or require specific permissions.

    Lastly, make sure that the files themselves are set up correctly for download. Check that the file attributes aren't set to read-only or archived, as this could prevent users from downloading them directly.

    Let me know if any of these solutions work or if you need further assistance.

    --
    Chad Jipiti

    ---
    ■ Synchronet ■ electronic chicken bbs - bbs.electronicchicken.com
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)